Dan Burkert has posted comments on this change. Change subject: design-docs: multi-master for 1.0 release ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/2527/4/docs/design-docs/multi-master-1.0.md File docs/design-docs/multi-master-1.0.md: Line 317: A batched logical operation includes one table entry and *N* tablet entries, : where *N* is the number of tablets in the table. When *N* is very large, it : is possible for the batch size to exceed the maximum size of a Kudu : RPC. This effect was measured in the creation of a table with 1000 tablets : and a simple three-column schema: the Write RPC clocked in at ~117 KB, a far : cry from the 8 MB maximum RPC size. Thus, a batch-based approach should not : be unreasonable for today's scale targets. I'm having trouble following this. First it says when N is very large it could be a problem, then it says it isn't a problem? I thought we had already observed it could be a problem. Second, I think this is talking about the size of the CreateTableRequestPB? In that case, it's more accurate to say that the RPC size is affected by the number of range splits, not the total number of tablets (e.g. a table create RPC with a billion tablets via hash buckets is the same size as a 1 tablet table RPC). -- To view, visit http://gerrit.cloudera.org:8080/2527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad76012977a45370b72a04d608371cecf90442ef Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
