Dan Burkert has posted comments on this change. Change subject: KUDU-1312 - design doc for scan token API ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/2443/4/docs/design-docs/scan-tokens.md File docs/design-docs/scan-tokens.md: Line 17: ## Motivation > This doesn't explain why scan tokens should be _serializable_. Could you ad Done Line 48: ByteBuffer serializedToken = tokens.get(0).serialize(); > No longer using ByteBuffer, though maybe the example is abstract enough tha Done Line 60: Scan tokens should be splittable so that intra-tablet parallelization can be : achieved. The client is better able to estimate appropriate primary key bounds : without requiring exposure of internal metrics in public client interfaces. > Could use some more color here. What would it mean to "split" a token? What Done -- To view, visit http://gerrit.cloudera.org:8080/2443 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id208cecababf15e1671a01a219d4599adfcd4163 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
