Hello Jean-Daniel Cryans, Mike Percy, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/2798
to review the following change.
Change subject: WIP: KUDU-1410 (part 5): rpc: sample each RPC method in several
latency buckets, expose on /rpcz
......................................................................
WIP: KUDU-1410 (part 5): rpc: sample each RPC method in several latency
buckets, expose on /rpcz
This changes RpczStore to keep several sample traces for each RPC, categorized
into several buckets (fast, slow, slower). Currently the thresholds for those
buckets are hard-coded, but follow-up work could make them adaptive based on
previous RPC percentiles, or user-configurable. Having tested this with a
YCSB workload, I found that they are useful even in this simple implementation.
WIP because this needs some new tests, though I've been testing this on a
YCSB workload and it is relatively useful.
Change-Id: I0eadb3f7035b5b156cb624ce50876876a5698b17
---
M src/kudu/rpc/inbound_call.h
M src/kudu/rpc/rpc_introspection.proto
M src/kudu/rpc/rpcz_store.cc
M src/kudu/rpc/rpcz_store.h
M src/kudu/server/rpcz-path-handler.cc
5 files changed, 206 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/2798/1
--
To view, visit http://gerrit.cloudera.org:8080/2798
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0eadb3f7035b5b156cb624ce50876876a5698b17
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Mike Percy <[email protected]>
