Adar Dembo has posted comments on this change. Change subject: KUDU-1410 (part 4): rpc: refactor call trace logging to new RpczStore class ......................................................................
Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/2797/5/src/kudu/rpc/messenger.h File src/kudu/rpc/messenger.h: Line 227: std::unique_ptr<RpczStore> rpcz_store_; Why hide it behind a unique_ptr? To avoid having to include rpcz_store.h here? http://gerrit.cloudera.org:8080/#/c/2797/5/src/kudu/rpc/rpcz_store.h File src/kudu/rpc/rpcz_store.h: Line 17: #ifndef KUDU_RPC_RPCZ_STORE_H : #define KUDU_RPC_RPCZ_STORE_H Let's use #pragma once. Line 34: virtual ~RpczStore(); You expect it to be subclassed? Line 36: void AddCall(InboundCall* c); Document? -- To view, visit http://gerrit.cloudera.org:8080/2797 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icaf607815177c71608e09b47386ef5fbd46d7673 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
