Adar Dembo has posted comments on this change. Change subject: KUDU-1377 (part 1): Add Env::NewTempRWFile() ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2814/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 510: if (errno == EINTR) continue; // Retry on EINTR. Do you find this cleaner than wrapping the pread() call with RETRY_ON_EINTR()? At least with the latter I have one macro to search to figure out where we have EINTR handling and where we don't. -- To view, visit http://gerrit.cloudera.org:8080/2814 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f095f5a59607248040020ff0b113ba2ffb35aa2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
