Adar Dembo has posted comments on this change. Change subject: Fix use after free in RowSetTree ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/2816/1/src/kudu/tablet/rowset_tree.cc File src/kudu/tablet/rowset_tree.cc: Line 116: rsit->min_key = std::move(min_key); : rsit->max_key = std::move(max_key); The use of std::move() here isn't for correctness, right? It's just to avoid the string copies, since we know we won't be using these local variables anymore? -- To view, visit http://gerrit.cloudera.org:8080/2816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id640ec1f1092a28cbba00becebb8ff2e81828b77 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
