Adar Dembo has posted comments on this change. Change subject: KUDU-1389. Retry on EINTR in more PosixEnv syscalls ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/2819/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 71: static_assert(std::is_signed<decltype(err)>::value == true, \ : #err " must be a signed integer"); What's this fanciness do? Prevent someone from using RETRY_ON_EINTR() with 'err' of an unsigned type? -- To view, visit http://gerrit.cloudera.org:8080/2819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26ed36b0a37aa6a252701d712704969014d6fa79 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
