Dan Burkert has posted comments on this change. Change subject: Non-covering Range Partitions design doc ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/2772/1/docs/design-docs/non-covering-range-partitions.md File docs/design-docs/non-covering-range-partitions.md: Line 69: but schema designers may find it useful to be able to use : both options > If you're concerned about the cognitive overhead of having both range bound The only reason to keep around split rows is ease of use, as shown by the example. Line 104: If : the client limits the scan to a non-existent range partition through either : predicates or primary key bounds no results will be returned at all. > I'm coming around to the always-no-error perspective. See Todd's argument b I don't see a logical place to draw the line where we would return an error. Is it when the primary key bounds limit the scan to a non-existing partition? Or the predicates, or a combination of both? I would also argue that the precedent set by SQL is that you don't return an error for a scan that can never return values (like with a predicate that can be proved to always return false). Line 107: > Right, you've answered my first question, but not the second. Or do you exp I don't think I can predict that, since it's completely up to the application. Line 121: only : recontacting the master after a configurable timeout. > I see, so the configurable timeout you wrote about is for "negative" lookup I've tried to clarify this in the latest draft, but the short answer is that the 'negative space' will be tracked by range. The master will only return locations for tablets which exist, so the client is able to determine the missing space from lack of tablets in the response. -- To view, visit http://gerrit.cloudera.org:8080/2772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e530eda60c00faf066c41b6bdb2b37f6d96a5dc Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Binglin Chang <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
