Todd Lipcon has posted comments on this change. Change subject: KUDU-1410 (part 1). Add per-Trace counters ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/2794/3/src/kudu/util/threadpool.h File src/kudu/util/threadpool.h: Line 64: // unbounded cardinality (a server may have thousands of differnet tablet IDs > Nit: different Done Line 65: In that case, set the prefix to "raft" to avoid issues. > It took me several readings to understand that if trace_metric_prefix is NO Done http://gerrit.cloudera.org:8080/#/c/2794/3/src/kudu/util/trace_metrics.h File src/kudu/util/trace_metrics.h: Line 17: #ifndef KUDU_UTIL_TRACE_METRICS_H : #define KUDU_UTIL_TRACE_METRICS_H > Let's start using "#pragma once" now that we're relying on C++11. Done -- To view, visit http://gerrit.cloudera.org:8080/2794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86001778976f01b62342f63f98b62962bc74212f Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
