Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1410 (part 2). rpc: clean up generated RPC service code ......................................................................
KUDU-1410 (part 2). rpc: clean up generated RPC service code This changes the generated RPC service code to extract the actual handling logic into a non-generated base class. The generated code now just generates a map of method name to MethodInfo, each of which contains the requisite information to handle an RPC. This results in a small reduction in lines of non-generated code, and a larger reduction in lines of generated code. Furthermore, this refactor makes it easier to make improvements and further cleanups on the RPC server side, since most changes now won't need to affect the code generator. Change-Id: Id7b42a5ba1de59315660a79b125e70938c3a1b2e Reviewed-on: http://gerrit.cloudera.org:8080/2795 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/rpc/protoc-gen-krpc.cc M src/kudu/rpc/service_if.cc M src/kudu/rpc/service_if.h 3 files changed, 92 insertions(+), 90 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/2795 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7b42a5ba1de59315660a79b125e70938c3a1b2e Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
