Adar Dembo has submitted this change and it was merged. Change subject: KUDU-1410 (part 5): rpc: sample each RPC method in several latency buckets, expose on /rpcz ......................................................................
KUDU-1410 (part 5): rpc: sample each RPC method in several latency buckets, expose on /rpcz This changes RpczStore to keep several sample traces for each RPC, categorized into several buckets (fast, slow, slower). Currently the thresholds for those buckets are hard-coded, but follow-up work could make them adaptive based on previous RPC percentiles, or user-configurable. Having tested this with a YCSB workload, I found that they are useful even in this simple implementation. Change-Id: I0eadb3f7035b5b156cb624ce50876876a5698b17 Reviewed-on: http://gerrit.cloudera.org:8080/2798 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <[email protected]> --- M src/kudu/rpc/inbound_call.h M src/kudu/rpc/rpc-test-base.h M src/kudu/rpc/rpc_introspection.proto M src/kudu/rpc/rpc_stub-test.cc M src/kudu/rpc/rpcz_store.cc M src/kudu/rpc/rpcz_store.h M src/kudu/server/rpcz-path-handler.cc 7 files changed, 265 insertions(+), 15 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/2798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0eadb3f7035b5b156cb624ce50876876a5698b17 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
