Todd Lipcon has posted comments on this change. Change subject: transaction: reduce initial arena block size ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2753/1/src/kudu/tablet/transactions/transaction.cc File src/kudu/tablet/transactions/transaction.cc: Line 35: arena_(1024, 4 * 1024 * 1024), > Nit: add a comment explaining the choice? it actually seems like almost all of our arenas throughout the code start with 1KB, so not sure this one specially needs a comment. Maybe we should get rid of these arguments and just have a kudu-wide default since we never have any particularly good reasons for the numbers we pick -- To view, visit http://gerrit.cloudera.org:8080/2753 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9250ffb7afd87c274ea29e1d1bf8daf6cafb8f28 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
