Todd Lipcon has posted comments on this change. Change subject: Add statistics in java client. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2858/1/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java: Line 2175: public void incrementWriteOps(String tableName, String tabletId, int count) { maybe we could avoid all of these redundant methods by doing something like: enum Statistic { WRITE_OPS(0), WRITE_RPCS(1), ...; Statistic(int idx) { this.idx = idx; } private final int idx; }; void incrementStatistic(String tableName, String tabletId, Statistic stat, int count) { getTabletStatistics(tableName, tabletId).stats[stat.idx].getAndAdd(count); } -- To view, visit http://gerrit.cloudera.org:8080/2858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9f06bcae7afac69772e55e85a020a4fe90ae845 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: zhen.zhang <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
