Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1415. Add statistics in java client. ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/2858/2/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java: Line 2150: public Statistics getStatistics(){ Oh I just thought of something, should we add a way to disable the collection of stats? Could be done in KuduClientBuilder (and the async one). http://gerrit.cloudera.org:8080/#/c/2858/2/java/kudu-client/src/main/java/org/kududb/client/Statistics.java File java/kudu-client/src/main/java/org/kududb/client/Statistics.java: Line 132: We should also have methods that do rollups, else it's not going to be fun querying all the tablets by hand to get global metrics. We should also add a toString() that uses the rollups, that way it's nice and easy to dump in the logs all the stats. -- To view, visit http://gerrit.cloudera.org:8080/2858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9f06bcae7afac69772e55e85a020a4fe90ae845 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: zhen.zhang <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: zhen.zhang <[email protected]> Gerrit-HasComments: Yes
