Dan Burkert has posted comments on this change. Change subject: change scope of jdiff to provided ......................................................................
Patch Set 1: I think it would be a runtime error if someone were to load the classes in tools/ which depend on jdiff, but since this shouldn't be done, it is fine. I'm also pretty confident that maven adds provided scope dependencies during compile time / site generation. -- To view, visit http://gerrit.cloudera.org:8080/2874 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9436404463cd02dba1b594a79040a21a74fd41f9 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
