Todd Lipcon has submitted this change and it was merged.
Change subject: sys_catalog: another band-aid to avoid races while shutting down
......................................................................
sys_catalog: another band-aid to avoid races while shutting down
I observed a test failure where the CHECK in SysCatalogStateChanged fired
because a master leader election finished just as the master was shut down.
To fix, we'll soften the CHECK to allow (and ignore) failures that happen
after the master has shut down.
Check failed: _s.ok() Bad status: Service unavailable: The pool has been shut
down.
*** Check failure stack trace: ***
@ 0x7f73820ad24d google::LogMessage::Fail() at ??:0
@ 0x7f73820af2bc google::LogMessage::SendToLog() at ??:0
@ 0x7f73820acda9 google::LogMessage::Flush() at ??:0
@ 0x7f73820afc4f google::LogMessageFatal::~LogMessageFatal() at ??:0
@ 0x7f738f0c9220
kudu::master::SysCatalogTable::SysCatalogStateChanged() at ??:0
@ 0x7f738f0d98fb kudu::internal::InvokeHelper<>::MakeItSo() at ??:0
@ 0x7f738f0d9616 kudu::internal::Invoker<>::Run() at ??:0
@ 0x7f738cb50148 kudu::internal::Invoker<>::Run() at ??:0
@ 0x7f738cb0442e boost::_bi::bind_t<>::operator()() at ??:0
@ 0x7f738659db6f boost::function0<>::operator()() at ??:0
@ 0x7f7383657d3c kudu::ThreadPool::DispatchThread() at ??:0
@ 0x7f738365f3ee boost::_bi::bind_t<>::operator()() at ??:0
@ 0x7f738659db6f boost::function0<>::operator()() at ??:0
@ 0x7f73836456b7 kudu::Thread::SuperviseThread() at ??:0
@ 0x7f738a591182 start_thread at ??:0
@ 0x7f73808e547d clone at ??:0
@ (nil) (unknown)
Change-Id: Iaf6cddee882bbaf3cf9b7198926799d013e14253
Reviewed-on: http://gerrit.cloudera.org:8080/2928
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <[email protected]>
---
M src/kudu/master/sys_catalog.cc
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/2928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf6cddee882bbaf3cf9b7198926799d013e14253
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
