Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1359. Fix some check_compatibility.py on OSX ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2944/1/build-support/check_compatibility.py File build-support/check_compatibility.py: Line 86: proto_filenames_file = "proto_filenames" > can you use NamedTemporaryFile instead? then you get auto-cleanup on failur Will do (didn't know about NamedTemporaryFile). Line 88: git_tar_cmd + " | tar -t | grep -a '\.proto' > %s" % proto_filenames_file], > why do you need grep -a here? it's binary? maybe '\.proto$' is better too, Yeah it's binary. Will add $. -- To view, visit http://gerrit.cloudera.org:8080/2944 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7954c44b21d247091dd6f542e7e5e8c5d658337 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
