Todd Lipcon has posted comments on this change. Change subject: rpc: use full configured timeout for connection negotiation ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/2948/1/src/kudu/rpc/connection.cc File src/kudu/rpc/connection.cc: Line 566: transfer > this status is never visible right? it gets shown in a VLOG(1) message in CallTransferCallbacks::NotifyTransferAborted(), but it doesn't make it back to the user. That said, the VLOG(1) there is no longer accurate, will fix it so that the connection shutdown status looks reasonable in both the user statuses and the log http://gerrit.cloudera.org:8080/#/c/2948/1/src/kudu/rpc/transfer.cc File src/kudu/rpc/transfer.cc: Line 146: return new OutboundTransfer(-1, payload, callbacks); > magic number? Done http://gerrit.cloudera.org:8080/#/c/2948/1/src/kudu/rpc/transfer.h File src/kudu/rpc/transfer.h: Line 146: 1 > magic number? Done Line 152: 0 > same Done -- To view, visit http://gerrit.cloudera.org:8080/2948 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3e284f8d879f2b0e0a62e4f29c445ae53c5ea2c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
