Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] Add AsyncKuduClient#syncClient ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2950/1/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java: Line 266: * Returns a synchronous {@link KuduClient} which wraps this asynchronous client. nit I would add something about the interactions between the two clients. For example, shutting down the returned sync client will shutdown this client. If this method is called multiple times, calling shutdown shuts all of them down. -- To view, visit http://gerrit.cloudera.org:8080/2950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I947ce53257454eb3a355f50127e796c6625ee3f2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
