Todd Lipcon has posted comments on this change. Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/2986/3/src/kudu/client/value.h File src/kudu/client/value.h: Line 46: static KuduValue* FromIntList(std::vector<int32_t> v_lst); yea, I think I agree with Dan's comment earlier that I don't think a list should be encapsulated in a Value, but instead it should be an entirely separate predicate from an API perspective. Otherwise it's sort of confusing -- what does it mean to be "less than a list" for example? Of course we can just return errors if someone tries to do something nonsensical like that, but maybe the code/usage would be more obvious as a separate type of predicate? Let's discuss, though, before spending a ton of time re-writing the other way, maybe I haven't thought of something here. -- To view, visit http://gerrit.cloudera.org:8080/2986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I986cb13097f1cf4af2b752f58c4c38f412a6a598 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sameer Abhyankar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sameer Abhyankar <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
