Adar Dembo has posted comments on this change. Change subject: Refactor cache interface to handle allocation of values and keys together ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2957/2/src/kudu/cfile/block_cache.h File src/kudu/cfile/block_cache.h: Line 62: } PACKED; > true it's not likely to insert padding, but it serves as a sort of indicato OK, but why would compiler inserted padding break anything? And you can answer that in a code comment. :) -- To view, visit http://gerrit.cloudera.org:8080/2957 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedeb24c0233bf062a0a6450a9fd3a7c57499144f Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
