Todd Lipcon has posted comments on this change. Change subject: sockaddr: improve hash function for better reactor load balancing ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/2939/4/src/kudu/util/net/sockaddr.cc File src/kudu/util/net/sockaddr.cc: Line 77: uint32_t hash = Hash32NumWithSeed(addr_.sin_addr.s_addr, 0); : hash = Hash32NumWithSeed(addr_.sin_port, hash); > The results speak for themselves, but how did you decide to use this partic "Trust in Google"! I just looked for hash functions that worked on 32-bit integers in our codebase and found this one. -- To view, visit http://gerrit.cloudera.org:8080/2939 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I650738cc628bb6ad67348c40753d777c9b566d61 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Binglin Chang <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
