zhen.zhang has posted comments on this change. Change subject: KUDU-1444. Get resource metrics of a scan. ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3013/2/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: Line 148: if (resource_metrics.has_cfile_cache_miss_bytes()) { : resource_metrics_.Increment("cfile_cache_miss_bytes", resource_metrics.cfile_cache_miss_bytes()); : } Seems it's better to iterate the fields of ResourceMetricsPB, or we have to write many similar codes, especially if we add more metrics in the future. But I've not found good methods to iterate. http://gerrit.cloudera.org:8080/#/c/3013/2/src/kudu/tserver/tserver.proto File src/kudu/tserver/tserver.proto: Line 302: ResourceMetricsPB As you said, we may have more metrics like spinlock contention etc, so maybe ResourceMetricsPB is more appropriate. If you have better name, please let me know. -- To view, visit http://gerrit.cloudera.org:8080/3013 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedaf570a7601651c93275ae0a8565f1e33da842d Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: zhen.zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: zhen.zhang <[email protected]> Gerrit-HasComments: Yes
