Adar Dembo has posted comments on this change. Change subject: rpc: LIFO service queue ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/2938/7/src/kudu/rpc/service_queue.cc File src/kudu/rpc/service_queue.cc: Line 41: consumers_.emplace_back(consumer); > yea, the idea is to avoid the memory leak, though I suppose we could instea I don't know if it's preferable (seems like six of one or half-dozen of the other) but yeah, doesn't need to happen now. -- To view, visit http://gerrit.cloudera.org:8080/2938 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd1eb677dd52f89683eb648b42918fcf51437215 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Binglin Chang <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
