Todd Lipcon has submitted this change and it was merged. Change subject: thread: enable stack watchdog for thread creation ......................................................................
thread: enable stack watchdog for thread creation In stress workloads, I see warnings fairly frequently that thread creation is slow (on the order of 1 second). It's not clear what triggers this behavior, yet, so this patch adds a stack watchdog to grab the kernel stack during slow thread creation. The only subtlety here is that starting the stack watchdog itself requires starting a thread, so to avoid a self-deadlock, we need to start the watchdog thread with a flag disabling watching itself. Change-Id: Ia423084d01716e5d4884d17cdf836a43489a6ebc Reviewed-on: http://gerrit.cloudera.org:8080/3005 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Todd Lipcon <[email protected]> --- M src/kudu/util/kernel_stack_watchdog.cc M src/kudu/util/kernel_stack_watchdog.h M src/kudu/util/thread.cc M src/kudu/util/thread.h 4 files changed, 45 insertions(+), 15 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Todd Lipcon: Verified -- To view, visit http://gerrit.cloudera.org:8080/3005 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia423084d01716e5d4884d17cdf836a43489a6ebc Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
