Adar Dembo has posted comments on this change. Change subject: Make the meta cache return Status::NetworkError if no addresses were found ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3027/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: Line 1555: google::FlagSaver saver; You shouldn't need this saver or the FLAG override; the previous saver went out of scope and so the FLAG value was restored. http://gerrit.cloudera.org:8080/#/c/3027/2/src/kudu/util/net/net_util.cc File src/kudu/util/net/net_util.cc: Line 51: DEFINE_bool(fail_dns_resolution, false, "Wether to fail all dns resolution, for tests."); Should be "Whether". You can fix in a follow-on patch. -- To view, visit http://gerrit.cloudera.org:8080/3027 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95b553f1db1b76f9e8117b6628c7bf64013d1ad9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
