Andy Grove has posted comments on this change. Change subject: Kudu Spark Datasource for insertions and updates ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/2992/4/java/kudu-spark/src/main/scala/org/kududb/spark/kudu/KuduContext.scala File java/kudu-spark/src/main/scala/org/kududb/spark/kudu/KuduContext.scala: Line 91: def tableExists(tableName: String) = syncClient.tableExists(tableName) > Is this returning a boolean? I think return type is mandatory in Scala. In this case the return type is inferred (syncClient.tableExists returns boolean). Adding ` : Boolean` may make it more readable ... it's down to style preference. -- To view, visit http://gerrit.cloudera.org:8080/2992 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74f20a6c17c47f424dfda62854963dc19c3b78c3 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Chris George <[email protected]> Gerrit-Reviewer: Andy Grove <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
