Adar Dembo has posted comments on this change. Change subject: Move the MetaCacheServerPicker into meta_cache.h/cc and make it a member of RemoteTablet ......................................................................
Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/3028/6/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: Line 38: using std::string; Resort this while you're here? Line 731: scoped_refptr<MetaCacheServerPicker> server_picker( Why create a new server picker on refresh? What stale state is in the existing picker that it needs to be replaced? http://gerrit.cloudera.org:8080/#/c/3028/6/src/kudu/client/meta_cache.h File src/kudu/client/meta_cache.h: Line 24: #include <string> While you're here, could you move this into sort order? Line 37: #include "kudu/rpc/rpc.h" Wrong sort order. -- To view, visit http://gerrit.cloudera.org:8080/3028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5344e9556f7042743458efbf1a5dc8be1e45f8da Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
