Adar Dembo has posted comments on this change. Change subject: RFC [java client] Redo how we manage exceptions ......................................................................
Patch Set 1: On Slack you also asked about Recoverable + NonRecoverable exception types vs. a single exception type with an isRecoverable() method. I think either are fine. With both exception types, if you don't care about the difference, you're going to catch KuduException instead. And if you do care, it's two catch statements vs. a single catch with an if() to separate them. Seems more or less the same to me. -- To view, visit http://gerrit.cloudera.org:8080/3055 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba6e8a022d7a5391c3657cbdc9d3f06f951be048 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
