Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3064
to look at the new patch set (#8).
Change subject: Add a generic retriable rpc class
......................................................................
Add a generic retriable rpc class
This patch adds a new, generic, class for retriable Rpcs: RetriableRpc.
This class will handle retry logic, such as setting id/sequence numbers on
the rpc header, as well as number of attempts.
Derived classes of RetriableRpc no longer have to deal with logic regarding
replica selection, proxy initialization or retrying. They just have to
implement:
Try() - Actually sends the rpc to a server.
AnalyzeResponse() - Buckets the response into a few, common, categories.
Finish() - Handle (final) success or failure.
This also refactors WriteRpc to use the new class.
Change-Id: Iaa58bdc5656a5d4d9172885a67363f74718a0c8e
---
M src/kudu/client/batcher.cc
A src/kudu/rpc/retriable_rpc.h
M src/kudu/rpc/rpc.h
3 files changed, 208 insertions(+), 114 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/3064/8
--
To view, visit http://gerrit.cloudera.org:8080/3064
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa58bdc5656a5d4d9172885a67363f74718a0c8e
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
