Todd Lipcon has posted comments on this change. Change subject: Add a request tracker to track client rpc sequence numbers ......................................................................
Patch Set 2: (1 comment) 10 minutes seems quite long, given our election timeout is on the order of a few seconds, and typical client timeouts are 30-60 seconds max. I'd like to see some back-of-the-envelope math on how much memory a 1-minute cache would look like given normal WriteResponses. http://gerrit.cloudera.org:8080/#/c/3078/2/src/kudu/rpc/request_tracker.cc File src/kudu/rpc/request_tracker.cc: Line 35: if (PREDICT_FALSE(incomplete_rpcs_.size() >= FLAGS_rpc_max_in_flight_linearizable_rpcs)) { > no, this is from the paper and it's meant to bound the number of outstandin Not quite following (admittedly haven't read the paper in a while). Isn't this a client side thing? How does that bound the server side? To me it seems like unnecessarily complexity until we see some problem. -- To view, visit http://gerrit.cloudera.org:8080/3078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23201625ca02f244dc94205d88dabc01608de471 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
