Todd Lipcon has submitted this change and it was merged.
Change subject: tablet: remove tablet_do_dup_key_checks flag
......................................................................
tablet: remove tablet_do_dup_key_checks flag
This flag was never safe to set to anything but 'true', and is a remnant from
some very early (Jan '13) prototyping efforts. Quoting the description of the
original commit (fd7cfd5cfb500eb8330b5787):
This isn't a sustainable flag, but rather just a stopgap until there
are bloom filter checks against the different layers. Disabling the
duplicate key checks speeds up inserts by an order of magnitude. The
assumption is that bloom filters will have a similar effect, but
this can be used in the meantime for benchmarking.
Removing it now as it will make sharing code between Insert and Upsert slightly
easier.
Change-Id: I883422aca12065926d98300aeed0493d2a956bfa
Reviewed-on: http://gerrit.cloudera.org:8080/3117
Reviewed-by: Adar Dembo <[email protected]>
Tested-by: Kudu Jenkins
---
M src/kudu/tablet/tablet.cc
M src/kudu/tserver/tablet_server-test.cc
2 files changed, 16 insertions(+), 23 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I883422aca12065926d98300aeed0493d2a956bfa
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
