Yeah that's good you caught it! +1 for the cherry-pick. On Wed, May 25, 2016 at 12:18 AM, Todd Lipcon <[email protected]> wrote:
> Another blocker that needs to be incorporated: > http://gerrit.cloudera.org:8080/#/c/3208/ > > On Tue, May 24, 2016 at 10:14 AM, Jean-Daniel Cryans <[email protected]> > wrote: > > > Those look good Todd, I added some comments to that effect in the > reviews. > > > > J-D > > > > On Mon, May 23, 2016 at 11:24 PM, Todd Lipcon <[email protected]> wrote: > > > > > I have a bunch of small fixes and improvements that I'd like to get > into > > > 0.9. For those that are already committed to master, I created > > cherry-pick > > > gerrits for them on 0.9.x ( > > > > > > > > > http://gerrit.cloudera.org:8080/#/q/status:open+project:kudu+branch:branch-0.9.x > > > should be an up-to-date list) > > > > > > There are a few that are still in review that I would like to get in: > > > > > > http://gerrit.cloudera.org:8080/#/c/3092/ (improvement to rpcz metrics > > for > > > diagnosing timeouts, etc) > > > http://gerrit.cloudera.org:8080/#/c/3186/ (perf improvement based on > > YCSB > > > benchmarks) > > > http://gerrit.cloudera.org:8080/#/c/3185/ (get rid of log spew for > queue > > > overflows, improved 99th percentile latency a lot) > > > http://gerrit.cloudera.org:8080/#/c/3184/ (java client exponential > > backoff > > > - also based on YCSB and some more cluster testing) > > > > > > Some others which are not my own patches but I think are worth > > considering: > > > http://gerrit.cloudera.org:8080/#/c/3142/ (NaN fix by Will, seems low > > > risk) > > > http://gerrit.cloudera.org:8080/#/c/3013/ (Resource Metrics, by Zhen - > > > this > > > is an improvement rather than fix, so maybe won't make it, but would be > > > nice since Zhen's been working on it a while) > > > > > > Lastly, I just filed this usability issue which is also causing 10%+ > > > flakiness on client-test: > > https://issues.apache.org/jira/browse/KUDU-1466 > > > . > > > I'm hoping this will be a pretty short fix of just a few lines of code, > > in > > > which case I think it's a good candidate for 0.9.0. > > > > > > -Todd > > > > > > > > > > > > On Mon, May 23, 2016 at 6:48 PM, Jean-Daniel Cryans < > [email protected] > > > > > > wrote: > > > > > > > Got it, Mike. One thing that worries me is that there's a lot of > > > > testing/documentation still needed for both and we're getting close > to > > > > release. If you find yourself short on time, my suggestion would be > to > > > > focus on one and to make sure it's extra solid. > > > > > > > > Other patches I'm +1 on cherry-picking: > > > > > > > > Upsert support in Flume: http://gerrit.cloudera.org:8080/#/c/3157/ > > > > Minimal client changes to support non-covering range partitioned > > tables: > > > > http://gerrit.cloudera.org:8080/#/c/3177/ > > > > Remove default partitioning: > http://gerrit.cloudera.org:8080/#/c/3131/ > > > > > > > > I'll also be cherry-picking a bunch of other patches myself. > > > > > > > > Thanks, > > > > > > > > J-D > > > > > > > > On Mon, May 23, 2016 at 3:03 PM, Mike Percy <[email protected]> > wrote: > > > > > > > > > I have a couple patches in flight that I'd like to get into 0.9.0: > > > > > > > > > > - http://gerrit.cloudera.org/#/c/3135/ > > > > > - http://gerrit.cloudera.org/#/c/3076/ > > > > > > > > > > They both need more work but I think in both cases it's doable this > > > week. > > > > > > > > > > Mike > > > > > > > > > > On Mon, May 23, 2016 at 2:59 PM, Jean-Daniel Cryans < > > > [email protected] > > > > > > > > > > wrote: > > > > > > > > > > > I'll send the list of pre-authorized patches/jiras that can go in > > > that > > > > > > branch later today, else please ping me on this thread or add me > on > > > the > > > > > > review. > > > > > > > > > > > > J-D > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > Todd Lipcon > > > Software Engineer, Cloudera > > > > > > > > > -- > Todd Lipcon > Software Engineer, Cloudera >
