PragmaTwice opened a new issue, #561: URL: https://github.com/apache/incubator-kvrocks/issues/561
The current `cmake/gtest.cmake` is confusing, especially since it contains a directory on [line 38](https://github.com/apache/incubator-kvrocks/blob/cf9901f88f5905f75e542999529fcbad2ec66dd1/cmake/gtest.cmake#L38) that does not exist, so this file does not seem to provide any functionality. The project uses the system-supplied gtest, which makes it difficult to control its version. It also seems that the project does not use mechanisms such as `find_package` for gtest, but relies directly on the system header directory (e.g. `/usr/include` to find `gtest/gest.h`) and the `-lgtest` link option. I think it would be better to reintroduce googletest with fixed tag/commit hash at the cmake level (source level) using `ExternalProject` or `FetchContent`. Since gtest doesn't have many translation units, it doesn't take long to compile. I'm happy to provide PRs if that sounds like a good idea. @tisonkun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
