PragmaTwice commented on code in PR #564: URL: https://github.com/apache/incubator-kvrocks/pull/564#discussion_r869138940
########## CMakeLists.txt: ########## @@ -15,7 +15,7 @@ # specific language governing permissions and limitations # under the License. -cmake_minimum_required(VERSION 3.10) +cmake_minimum_required(VERSION 3.16) Review Comment: Yeah, use 3.16 just because it is the default version in apt repo of ubuntu 20.04. But I highly recommend a newer version of cmake. [A good post](https://www.scivision.dev/cmake-changelog) described its advantages. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
