PragmaTwice commented on PR #576: URL: https://github.com/apache/incubator-kvrocks/pull/576#issuecomment-1125752292
> @PragmaTwice we may still keep some targets in Makefile such as lints to running checker. > > In a separated pass we can consider whether adopt Makefile to do such job or port them in scripts or other approaches. > > NOTICE: CI failed because of `make lint` missing a Makefile. I think `lint` is the only target which is out of the responsibility of cmake (not sure, becuase actually it can be written into cmake), and it is quite simple, only call two scripts, `cppcheck.sh` and `cpplint.sh`. Hence I consider to remove the target to delete all Makefiles to make sure these handwritten makefiles will not conflict with cmake-generated makefiles (i.e. call `cmake .` directly on the root directory of the project, which will overwrite current makefiles). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
