torwig commented on code in PR #577:
URL: https://github.com/apache/incubator-kvrocks/pull/577#discussion_r873165180
##########
src/lock_manager.cc:
##########
@@ -51,3 +51,7 @@ void LockManager::Lock(const rocksdb::Slice &key) {
void LockManager::UnLock(const rocksdb::Slice &key) {
mutex_pool_[hash(key)]->unlock();
}
+
+void LockManager::LockTwo(const rocksdb::Slice &first_key, const
rocksdb::Slice &second_key) {
+ std::lock(*mutex_pool_[hash(first_key)], *mutex_pool_[hash(second_key)]);
Review Comment:
I added a check that will track the case when two indexes from the mutex
pool are the same. In that case, the second index will be increased to point to
reference different mutex. Does it have any drawbacks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
