ShooterIT commented on code in PR #538:
URL: https://github.com/apache/incubator-kvrocks/pull/538#discussion_r876916825
##########
src/replication.cc:
##########
@@ -466,10 +468,39 @@ ReplicationThread::CBState
ReplicationThread::replConfReadCB(
ReplicationThread::CBState ReplicationThread::tryPSyncWriteCB(
bufferevent *bev, void *ctx) {
auto self = static_cast<ReplicationThread *>(ctx);
- auto next_seq = self->storage_->LatestSeq() + 1;
- send_string(bev, Redis::MultiBulkString({"PSYNC",
std::to_string(next_seq)}));
+ auto cur_seq = self->storage_->LatestSeq();
+ auto next_seq = cur_seq + 1;
+ std::string replid;
+
+ // Get replication id
+ std::string replid_in_wal = self->storage_->GetReplIdFromWalBySeq(cur_seq);
+ // Set if valid replication id
+ if (replid_in_wal.length() == kReplIdLength) {
+ replid = replid_in_wal;
+ } else {
+ // Maybe there is no WAL, we can get replication id from db since master
+ // always write replication id into db before any operation when starting
+ // new "replication history".
+ std::string replid_in_db = self->storage_->GetReplIdFromDbEngine();
Review Comment:
Maybe empty WAL, as we know, wal may be not persistent in disk after
restarting server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
