torwig commented on PR #594:
URL:
https://github.com/apache/incubator-kvrocks/pull/594#issuecomment-1136853333
@ShooterIT I replaced Pop implementation with multi-pop's one and pushed.
Or do you think I should implement Pop like this:
```
rocksdb::Status List::Pop(const Slice &user_key, bool left, std::string
*elem) {
std::vector<std::string> elems;
auto s = PopMulti(user_key, left, 1, &elems);
if (!s.ok()) return s;
*elem = elems[0];
return rocksdb::Status::OK();
}
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
