tisonkun commented on code in PR #610:
URL: https://github.com/apache/incubator-kvrocks/pull/610#discussion_r884305903
##########
src/config.cc:
##########
@@ -449,26 +449,17 @@ void Config::initFieldCallback() {
}},
{"rocksdb.max_bytes_for_level_base", [this](Server* srv, const
std::string &k, const std::string& v)->Status {
if (!srv) return Status::OK();
- if (!RocksDB.level_compaction_dynamic_level_bytes) {
Review Comment:
It seems another option and with this patch you remove all usages of this
config. There must be a motivation and if you remove all usages, perhaps it's
necessary to remove the option also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
