git-hulk commented on code in PR #614:
URL: https://github.com/apache/incubator-kvrocks/pull/614#discussion_r886265248
##########
.github/workflows/kvrocks.yaml:
##########
@@ -88,11 +88,11 @@ jobs:
- name: Install Dependencies
run: |
- brew install gcc autoconf automake libtool cmake
+ brew install autoconf automake libtool cmake
mkdir build
- name: Build
run: |
cd build
- cmake ..
+ cmake .. -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++
Review Comment:
So can we remove CMAKE_CXX_COMPILER/CMAKE_C_COMPILER? since we can
workaround it when failing to build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
