tisonkun commented on code in PR #620:
URL: https://github.com/apache/incubator-kvrocks/pull/620#discussion_r889590278
##########
src/storage.cc:
##########
@@ -209,9 +210,16 @@ Status Storage::CreateColumnFamilies(const
rocksdb::Options &options) {
tmp_db->Close();
delete tmp_db;
}
- // Open db would be failed if the column families have already exists,
Review Comment:
Sorry I just (again, haha) revert the boolean logic :P
Ping me when you have a conclusion on whether use rfind or keep strncasecmp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
