GitHub user GoGim1 created a discussion: replace unique_ptr constructor with `MakeUnique` or `UniqueIterator`
ref https://github.com/apache/incubator-kvrocks/pull/711#discussion_r913359020 ref https://github.com/apache/incubator-kvrocks/pull/703#discussion_r912320795 I noticed there are many places in the code base where used the unique_ptr constructor directly instead of using `MakeUnique` and `UniqueIterator`. Do we need to replace them all? I wonder if this fix is worth PRs as it is too trivial and doesn't seem to bring performance benefits. GitHub link: https://github.com/apache/incubator-kvrocks/discussions/719 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected]
