Thanks, Xiaoqiao Agree that we should fix all issues as possible, see whether others have more suggestions or not, then we can fix all of them before the next vote.
On Wed, 20 Jul 2022 at 17:47, Xiaoqiao He <hexiaoq...@apache.org> wrote: > +0, > > - Verified signature and checksum of the source. > - Built successfully from the source on MacOS by `x.py build`. > - No binary files in the src distribution except ./docs/images, it is fine. > - DISCLAIMER and NOTICE look good, LICENSE only includes Apache License > v2.0, but some other dependencies don't declare License which is necessary. > - Some source files don't contain ASF headers, such as ./src/version.h. > > Overall, +0 from me. IMO we should fix Apache header for some source files, > update LICENSE declare and some other issues and try another RC. Good luck. > > Best Regards, > - He Xiaoqiao > > > On Wed, Jul 20, 2022 at 1:05 PM Yuan Wang <wangy...@apache.org> wrote: > > > +1 (binding) > > > > I checked: > > > > - sha512 is OK > > - tag is OK, > > https://github.com/apache/incubator-kvrocks/releases/tag/v2.1.0 > > - DISCLAIMER, NOTICE, LICENSE files are OK > > - no binary file > > > > > > hulk <hulk.webs...@gmail.com> 于2022年7月20日周三 10:36写道： > > > > > +1 (binding) > > > > > > I checked: > > > > > > - built on macOS is good with `x.py build > > > - hash/checksum is OK > > > - DISCLAIMER, NOTICE, LICENSE files are there > > > > > > On Tue, 19 Jul 2022 at 16:34, hulk <hulk.webs...@gmail.com> wrote: > > > > > > > Thanks, JB. > > > > > > > > I don't know that ASF headers are also required in docs, we can move > > > those > > > > docs to our website and only keep README. > > > > > > > > > > > > On Tue, 19 Jul 2022 at 15:49, Jean-Baptiste Onofré <j...@nanthrax.net> > > > > wrote: > > > > > > > >> +1 (binding) > > > >> > > > >> I checked: > > > >> - incubating is in the name > > > >> - DISCLAIMER, NOTICE, LICENSE files are there (maybe we have to > check > > > >> NOTICE about dependencies license) > > > >> - no binary files in the src distribution (only the png images from > > the > > > >> doc) > > > >> - some files don't contain ASF headers (README.md, some md in the > > > >> docs, etc). It could be problematic for the release. So, I'm voting > +1 > > > >> for this release if we fix this for the next release. > > > >> - hash/checksum is OK > > > >> > > > >> Regards > > > >> JB > > > >> > > > >> On Tue, Jul 19, 2022 at 4:45 AM donghui liu <ldh6815...@gmail.com> > > > wrote: > > > >> > > > > >> > +1 > > > >> > > > > >> > hulk <hulk.webs...@gmail.com> 于2022年7月18日周一 14:58写道： > > > >> > > > > >> > > Hi all, > > > >> > > > > > >> > > This s a call for the vote to release Apache Kvrocks(incubating) > > > >> v2.1.0 > > > >> > > > > > >> > > The release candidate: > > > >> > > > > > >> > > https://dist.apache.org/repos/dist/dev/incubator/kvrocks/2.1.0/ > > > >> > > > > > >> > > > > > >> > > Keys to verify the release candidate: > > > >> > > > > > >> > > https://downloads.apache.org/incubator/kvrocks/KEYS > > > >> > > > > > >> > > > > > >> > > Git tag for the release: > > > >> > > > > > >> > > https://github.com/apache/incubator-kvrocks/releases/tag/v2.1.0 > > > >> > > > > > >> > > > > > >> > > Changelog for the release: > > > >> > > > > > >> > > v2.1.0 changelog > > > >> > > < > > > >> > > > > > >> > > > > > > https://github.com/apache/incubator-kvrocks/commit/d163b26931ccb2aa2eb067e0d3b9ef133d454ca0#diff-ead07c84baac57a9542f388a07a2a5209456ce790b04251bc9bd7d179ea85cb1R2-R68 > > > >> > > > > > > >> > > > > > >> > > > > > >> > > The vote will be open for at least 72 hours or until the > necessary > > > >> number > > > >> > > of votes is reached. > > > >> > > > > > >> > > > > > >> > > If approved we will seek final release approval from the IPMC. > > > >> > > > > > >> > > > > > >> > > Please vote accordingly: > > > >> > > > > > >> > > [ ] +1 approve > > > >> > > > > > >> > > [ ] +0 no opinion > > > >> > > > > > >> > > [ ] -1 disapprove with the reason > > > >> > > > > > >> > > -- > > > >> > > Best Regards, > > > >> > > - *Hulk Lin* > > > >> > > > > > >> > > > > > > > > > > > > -- > > > > Best Regards, > > > > - *Hulk Lin* > > > > > > > > > > > > > -- > > > Best Regards, > > > - *Hulk Lin* > > > > > > -- Best Regards, - *Hulk Lin*
