-1 binding + Checksum and GPG sign correct + LICENSE, NOTICE and DISCLAIMER files exist + Build from source via `./x.py build` + Communicate kvrocks with redis-cli and all things fine. + No binary files bundled.
- Version info incorrect (2.1.0-rc1, should be 2.1.0) - tarball contains -rc1 suffix I mentioned in a previous email[1] that a release candidate should be able to be promoted as a release as is. The exception is we may push a formal git tag after the release passes voting, while git tag isn't itself part of a release. Best, tison. [1] https://lists.apache.org/thread/pd4lql62ffbb578w8rp5fok45gnn37th hulk <[email protected]> 于2022年7月27日周三 13:08写道： > +1 (binding) > > I checked: > - download links are valid > - hash and checksum verified ok > - ASF header is present in source files > - LICENSE, DISCLAIMER, and NOTICE exists and looks good > - no binary found in the src distribution > > > On Wed, 27 Jul 2022 at 13:04, Jean-Baptiste Onofré <[email protected]> > wrote: > > > +1 (binding) > > > > I checked: > > - incubating is in the name > > - hash and checksum look good > > - ASF header is present in source files > > - LICENSE, DISCLAIMER and NOTICE are there and look good > > - no binary found in the src distribution > > > > Thanks ! > > Regards > > JB > > > > On Tue, Jul 26, 2022 at 11:10 AM hulk <[email protected]> wrote: > > > > > > Hello, Apache Kvrocks(incubating) PMC and Community, > > > > > > This is a call for a vote to release Apache Kvrocks(incubating) version > > > 2.1.0-rc1. > > > > > > The tag to be voted on is 2.1.0-rc1: > > > > > > The release candidate: > > > > > > https://dist.apache.org/repos/dist/dev/incubator/kvrocks/2.1.0-rc1/ > > > > > > Keys to verify the release candidate: > > > > > > https://downloads.apache.org/incubator/kvrocks/KEYS > > > > > > Git tag for the release: > > > > > > https://github.com/apache/incubator-kvrocks/releases/tag/v2.1.0-rc1 > > > > > > Please download, verify, and test. > > > > > > The VOTE will remain open for at least 72 hours. > > > > > > [ ] +1 approve > > > > > > [ ] +0 no opinion > > > > > > [ ] -1 disapprove with the reason > > > > > > > > > To learn more about apache kvrocks, please see > > https://kvrocks.apache.org/ > > > > > > Checklist for reference: > > > > > > [ ] Download links are valid. > > > > > > [ ] Checksums and signatures. > > > > > > [ ] LICENSE/NOTICE files exist > > > > > > [ ] No unexpected binary files > > > > > > [ ] All source files have ASF headers > > > > > > [ ] Can compile from source > > > > > > [ ] All Tests Passed > > > > > > > > > Thanks, Your Kvrocks(incubating) Release Manager > > > > > > > > > -- > > > Best Regards, > > > - *Hulk Lin* > > > > > -- > Best Regards, > - *Hulk Lin* >
