I agree with the influence of clearing all the changes being made and the risk 
of reseting the configuration. Thanks.


> On Mar 26, 2016, at 11:07 PM, ShaoFeng Shi <[email protected]> wrote:
> 
> My suggestion is "don't make it too smart"; the configurations in
> kylin.properties should be static, which not intend to be updated often.
> Some configurations are very basic which impact on the whole system; it is
> not easy to dynamically change without a restart.
> 
> You also need consider the cluster mode, as the "Refresh"/"Set" request is
> only sent to one REST server, to take effective all nodes need be
> notified/syncronized.
> 
> 
> 2016-03-26 20:15 GMT+08:00 hongbin ma <[email protected]>:
> 
>> On Sat, Mar 26, 2016 at 7:36 AM, Zhong, Yanghong <[email protected]
>>> 
>> wrote:
>> 
>>> After a property be updated by “Set Config”, the left TextArea’s contents
>>> be updated automatically.
>>> 
>> 
>> ​this  looks great to me
>> ​
>> 
>> 
>>> After the “refresh” button clicked for “Server Config”, kylin loads
>>> contents from the configuration file “kylin.properties” and updates the
>> UI.
>>> 
>> 
>> ​I'm not sure if this looks intuitive to users. It makes it look like
>> "reset" config rather than "refresh" config. After all the changes made in
>> "Set config" is not persisted to the configuration file. ​A brutal reload
>> will clear all the changes being made.
>> 
>> 
>> 
>> --
>> Regards,
>> 
>> *Bin Mahone | 马洪宾*
>> Apache Kylin: http://kylin.io
>> Github: https://github.com/binmahone
>> 
> 
> 
> 
> -- 
> Best regards,
> 
> Shaofeng Shi


Reply via email to