I was probably the key person behind forking Calcite for Drill's purpose (3+ years ago). It was mostly driven by being unable to get key patches into Calcite. It has become a mistake. I suggest you avoid making the same one. Calcite is moving too quickly and you'll fall behind and be stuck in fork-land.
- If you can't get something merged and that is your impetus, please elevate that discussion. - If you need more frequent releases, you need to ask for them. For the second item, if you or someone else on Kylin becomes PMC/committer, you can also get to the point where you are someone who can drive these point releases. Looking at history, no one in the Calcite community has ever said "no, we can't do another release". Someone says "let's do a release" and then we do one. > > From: hongbin ma <[email protected]> > > Subject: [DISCUSS] fork Calcite and include the fork as a a submodule > > Date: April 16, 2017 at 7:39:12 AM PDT > > To: dev <[email protected]>, [email protected] > > > > Recently I'm testing kylin connectivity with multiple BI tools like > Tableau, Cognos, etc. During the test I find it necessary to fix several > Calcite issues, like CALCITE-1754. I'm more than willing to contribute the > fixes back to calcite, however there're still two potential issues: > > > > 1. Calcite has it's own release cycles, sometimes we cannot afford to > wait for calcite's next release > > 2. Some dirty hacks (yet still necessary) is not likely to be accepted > by Calcite. Currently there's a weird sub-project called "AtopCalcite" in > Kylin to host all the dirty hacks. > > > > With the above two issues, I'm wondering what is the best way to > interact with Calcite releases. I'm suggesting that: > > > > 1. We fork Apache Calcite and call it sth like calcite-for-kylin > > 2. Upon each calcite fix from our side, we double-commit to both Apache > Calcite and calcite-for-kylin > > 3. For dirty hacks we only push code to calcite-for-kylin > > 4. calcite-for-kylin should be updated upon each Apache Calcite release > > > > Any comment are welcomed! > > @Julian Looking forward to your comments as well > > > > -- > > Regards, > > > > Bin Mahone | 马洪宾 > >
