Do we create pull request or attach a patch to JIRA? I am little confuse. As 'How to contribute' document says to attach a patch but I also see pull requests on github pages.
My patch is here. https://issues.apache.org/jira/browse/KYLIN-2745 Please advice on process. This is my first commit. Thanks, Nirav On Tue, Jul 18, 2017 at 8:59 AM, Nirav Patel <[email protected]> wrote: > Thanks. Is it okay if I create a patch from my own fork repo and attach it > to JIRA? will you be still able to inspect and apply? > > On Mon, Jul 17, 2017 at 6:12 PM, ShaoFeng Shi <[email protected]> > wrote: > >> Hi Nirav, >> >> It need permission in JIRA system. Let me grant you the role then you will >> be the owner. >> >> 2017-07-18 6:27 GMT+08:00 Nirav Patel <[email protected]>: >> >> > Hi, >> > >> > Do we see this as a valid JIRA? Please comment. I couldn't put JIRA into >> > any sprint nor could assign it to myself. Should I be able to assign it >> to >> > myself? >> > >> > Thanks, >> > Nirav >> > >> > ---------- Forwarded message ---------- >> > From: nirav patel (JIRA) <[email protected]> >> > Date: Mon, Jul 17, 2017 at 3:23 PM >> > Subject: [jira] [Created] (KYLIN-2745) Remove eclipse .settings >> directory >> > from each module >> > To: [email protected] >> > >> > >> > nirav patel created KYLIN-2745: >> > ---------------------------------- >> > >> > Summary: Remove eclipse .settings directory from each >> module >> > Key: KYLIN-2745 >> > URL: https://issues.apache.org/jira/browse/KYLIN-2745 >> > Project: Kylin >> > Issue Type: Task >> > Reporter: nirav patel >> > >> > >> > I think this directory should not be part of git repo at all. It should >> be >> > listed in .gitignore file. >> > >> > >> > >> > -- >> > This message was sent by Atlassian JIRA >> > (v6.4.14#64029) >> > >> > -- >> > >> > >> > [image: What's New with Xactly] <http://www.xactlycorp.com/email-click/ >> > >> > >> > <https://www.nyse.com/quote/XNYS:XTLY> [image: LinkedIn] >> > <https://www.linkedin.com/company/xactly-corporation> [image: Twitter] >> > <https://twitter.com/Xactly> [image: Facebook] >> > <https://www.facebook.com/XactlyCorp> [image: YouTube] >> > <http://www.youtube.com/xactlycorporation> >> > >> >> >> >> -- >> Best regards, >> >> Shaofeng Shi 史少锋 >> > > -- [image: What's New with Xactly] <http://www.xactlycorp.com/email-click/> <https://www.nyse.com/quote/XNYS:XTLY> [image: LinkedIn] <https://www.linkedin.com/company/xactly-corporation> [image: Twitter] <https://twitter.com/Xactly> [image: Facebook] <https://www.facebook.com/XactlyCorp> [image: YouTube] <http://www.youtube.com/xactlycorporation>
