Re: Review Request 63946: KYLIN-3049 Filter the invalid zero value of "Auto Merge Thresholds" parameter when you create or upate a cube.

[pengjianhua]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63946/
-----------------------------------------------------------

(Updated 十一月 27, 2017, 9:27 a.m.)


Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.


Changes
-------

Thanks for your suggestion, I have updated the patch.
1. modify the $scope.prepareCube function
2. add the function 'removeElementInArrayByValue' in utils.js
please check it, thanks!


Bugs: KYLIN-3049
    https://issues.apache.org/jira/browse/KYLIN-3049


Repository: kylin


Description
-------

1. Open the Model page;
2. Create a new cube, click the "New Thresholds" button in the "Refresh 
Setting" tab, and don't input any value, then complete the follow steps, at 
last save it;
3. Choose the cube you just created, go to the "Refresh Setting" tab, you will 
find the zero hours in "Auto Merge Thresholds" list, which is invalid but saved 
in the server;
4. Similarly, update a existent cube, do the same steps, you will also find the 
invalid zero value saved in the server.
As we know, the zero value of "Auto Merge Thresholds" parameter is invalid, so 
we should filter it before sending it to server.


Diffs (updated)
-----

  webapp/app/js/controllers/cubeEdit.js 5f78b61 
  webapp/app/js/utils/utils.js 30ad261 


Diff: https://reviews.apache.org/r/63946/diff/3/

Changes: https://reviews.apache.org/r/63946/diff/2-3/


Testing
-------


Thanks,

pengjianhua