-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64157/
-----------------------------------------------------------
Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.
Bugs: KYLIN-3061
https://issues.apache.org/jira/browse/KYLIN-3061
Repository: kylin
Description
-------
There are two bugs in this issue.
First
1. Choose one streaming table, choose the 'Streaming Cluster' tab, then click
'Edit' button
2. The edit page will be opened, then you can edit the value of topic of 'Kafka
Setting'. As long as you modify the ID, Host, Port value, the original value
tag will follow changes
3. When you click 'cancel' button, you will find the old values have been
changed to the new values, and if you click the 'submit' button, you will also
find the values to be canceled will be submitted
But I think the correct way should be that 'cancel' button will not change any
value.
Second
The follow code in streamingConfig.js has a bug, even if "cluster.newBroker"
object matchs the one element of "cluster.brokers" array, this "if" decision
will return false. Because even though the "cluster.newBroker" object has the
same attribute values as an element in the array, their storage addresses may
be different. The result is that you can add several same record, like
can_add_the_same_record.png.
$scope.saveNewBroker = function(cluster) {
if (cluster.brokers.indexOf(cluster.newBroker) === -1) {
......
}
}
So I have repaired these two bugs, please check the patch, thanks!
Diffs
-----
webapp/app/js/controllers/streamingConfig.js 32b09c6
webapp/app/js/utils/utils.js 9c92a02
Diff: https://reviews.apache.org/r/64157/diff/1/
Testing
-------
Thanks,
pengjianhua
